Okay
  Public Ticket #797281
Adsense issue, few bugs - Few Suggestions
Closed

Comments

  • Pawan started the conversation

    I bought SNews theme couple of hours ago.  For some reason, Adsense AD's don't work with the given slots (top - mid - bottom). The ADsense code is correct. Kindly fix the bug ASAP. (i've added the adsense code at top so that you can check)

    I also have some suggestions - 

    1. You should consider adding AD slot before post content, After post content or Above Author box (best place for taboola content ads).

    2. Is it possible to replace Plane like share button to simple Share image?

    3. Structured data tool shows error in breadcrumbs (value of title field is required and value of url field is required)

    4. You can also include Source 1 / 2 and Via 1 / 2 area. Required for Tech website :)

    Update (found few bugs)

    5. Check out the attached screen shots. Layout for category in mobiles goes out of the box. See the image, you'll understand. http://imgur.com/gallery/6aMpvOo

    6. You should include Widgets that support both category and / or tags.

    Updates

    7. How to set Author Page?

    8. Can you please add typography into theme? (like quotes with author, tables, buttons, bars etc. etc.)

    9. Click on featured image should open image. Why doe it reload the post?
    Layout is cool, Love it. just a few touch ups bro


    Regards,

    Pawan


  • Pawan replied

    This image is from iPhone 5. Look how the image and text goes out of box. This majorly happens in Categories post.

    Moreover, double AD widget also isn't working. Single AD works fine. (top - middle - bottom does not work).

    You should also consider making Widgetized category blog page.


    (P.S.) do read the first reply, this is a follow up.

  •  93
    djwd replied

    Hi there,
    thanks for your detailed feedback. Please consider this is the very first release so improvements will be made along the way, including bug fixes.

    0. You're the second buyer reporting this about AdSense, so it's likely to be a bug. I'll look into this and release a fix asap.

    1. Will consider that, thanks. After/before post content can be entered directly in the post, of course that wouldn't allow to do it globally for all posts which might be what you're seeking for.

    2. I'm considering adding another layout option for sharing buttons to make them more visible. Changing the paper plane icon would be possible although it would require modifying the template.

    3. Noticed that, will be fixed asap.

    4. Sorry I didn't get this one, could please rephrase? :) Thanks

    5. Try by pasting this in the Custom CSS textarea (Advanced Tab) please.

    @media screen and (max-width: 1200px) {
    
        article.snews-classic-blog-hentry { 
           min-width: initial;
        }
    }

    6. Will consider that, thanks.

    7. The author page (like this one) kind of sets up itself automatically at this url: http://www.domain.com/author/username/, you just to need to fill author info in Wordpress Settings > Your Profile. 

    8. Working on this for next updates. You can already use titles, quotes and buttons into posts by using the correct markup. E.g <cite>This is a quote</cite> or <h2>Title</h2>

    9. It was like that before, I had to remove the feature because of some restrictions during the theme review process. Will restore it asap.

    Regards
    djwd

  • Pawan replied

    5. CSS fixed the issue. Please include it by default in next update :)

    4. See the attached image, you should get the idea.

    7. The http://www.techandroids.com/author/taadmin/ redirects to homepage for some reason (i've no idea why). Profile is already updated. 

    I also suggest you to include a special author page which just lists multiple authors (only a list with few sample post titles).

    UPDATES:

    A1 - In case you missed out, double AD widget is also not working.

    A2 - The featured image automatically crops the picture (usually vertical images) instead of resizing. For this reason i've to use small featured vertical image. Here is an example -  http://www.techandroids.com/ulefone-u007-budget-phone-5-inch-display-available-59-99/

    Keep up the good work, best of luck.

    Regards,

    Pawan

  •  93
    djwd replied

    Hi there!

    For the Google AdSense issue (not widgets, but Theme Options > Ads ), you may want to try this fix, if you do kindly let me know if that worked.

    5. Will do :)

    4. Got it! Thank you very much for the screenshot and suggestion. Will consider it.

    7. Can't reproduce that, not sure this is a bug, seems to be specific to your configuration. Kindly try by resetting your permalinks and let me know if that helps. Thanks for the suggestion as well, would be nice indeed.

    ----------

    A1. Got it thanks, looking into this I'll keep you posted.

    A2. That is the default behavior, images will be cropped to 750x400px in order to fit the area without distortion, for this reason is strongly advisable to upload bigger images. The cropping is controlled by native WordPress function, although there are third party plugins that will let you control the cropping position.

    Hope that helps

    Regards
    djwd

  • Pawan replied

    Adsense fix in functions.php is not working


  •  93
    djwd replied

    You sure you made the change and updated correctly? I'm asking as it worked for me and the other buyer having same issue. If you want please provide admin access I'll check myself (please mark the post as private).

    Thank you

    Regards
    djwd

  •   Pawan replied privately
  •  93
    djwd replied

    Hi there,
    the Adsense display issue was fixed, all modifications I made to your template files will also be bundled in next update. I also took the liberty to add some top padding to the top ad to better align it to the logo, feel free to remove it (in Advanced Tab > Custom CSS).

    I also dug in about the Loader problem, although it doesn't seem to be related to the Ads thing (hence the function). I say this as I tried removing all Ads instances on a single post page, but the problem persists. Can't replicate it on my end after having the same mods. Furthermore no JS error is triggered in your console.

    Even if it might seems odd, I would try disabling plugins as first troubleshooting, I wanted to do it myself but didn't want to break anything.


    Update: I see you have caching systems enabled, it would be better to disable it while troubleshooting.

    Regards
    djwd

  • Pawan replied

    you can play with plugins,  just dont deactivate seo yoast

  • Pawan replied

    Update:

    C1 - ADs are working. Small issues though. The Header AD (besides logo) isn't showing up on mobiles.

    C2 - The padding is way too much (at least that's what i feel) Check img-1. You'll get an idea & I think this suggestion will be welcomed by all. (notice the reduce padding 1 is original while 2/3 are just what i think should be) I am just trying to make you theme best.

    C3 - You have to include an ad slot above author box or just after post content. (IMG-2)

    Waiting for an update soon. With fixes and new features :)

    Regards,

    Pawan

  •  93
    djwd replied

    Hi there

    C1. Fixed for the next upcoming update, thanks for your feedback.

    C2. Thank you for the suggestion and effort. Spacing is designed very carefully and consistent throughout the site, this is also a strict requirement for TF review process. Please always consider this is a stock template, you can still customize it to fit your specific needs/taste by using child themes.

    C3. I'll consider this, thanks for the screenshot. ( Child themes would also allow you to override theme templates, so you can add ad slots everywhere you think it would fit best without losing your customizations after a theme update.)

    Regards
    djwd

  • Pawan replied

    7. The http://www.techandroids.com/author/taadmin/ redirects to homepage for some reason (i've no idea why). Profile is already updated. (previous question)

    7 Reply - 

    Can't reproduce that, not sure this is a bug, seems to be specific to
    your configuration. Kindly try by resetting your permalinks and let me
    know if that helps. Thanks for the suggestion as well, would be nice
    indeed.

    7 Update - I just checked the SNews demo. The link there also redirects to homepage. I did reset permalinks but the redirection is there.

    ------------------

    You should include the Child theme by default as all the previous themes i had did include it.

    I also see a new Theme update today. Download it. Can you direct me to change log?

  •  93
    djwd replied

    Hi there!

    7. What demo are you referring to? The main demo at http://snews.djwd.me doesn't redirect me, I can successfully see the author page at http://snews.djwd.me/author/snews/, can't you?

    I used to include child theme folder, I dropped this practice as it was resulting confusing to some inexperienced users, while should be something really quick and easy to setup for advanced users.

    Here's the changelog

    Regards
    djwd

  • Pawan replied

    Author issue fixed. Turns out, i had disabled Author archive in SEO Yoast :)

  •  93
    djwd replied

    Hi there,
    glad to hear that was sorted!

    Regards
    djwd

  • Pawan replied

    Hey there,

    I've come across 1 more bug (not exactly but requires fix).

    The theme's default social buttons are on featured image bottom right corning. I was going through it and i noticed that whenever i try to share to post, i hover over that paper plan, revealing social buttons on image. Whenever i click on any social button (lets say facebook). It does open sharing button but also opens the image (img url).  (tested on desktop).

    Regards,

    Pawan

  •  93
    djwd replied

    Hi there,
    I'll look into this, thanks for your feedback!

    Regards
    djwd

  • Pawan replied

    Hello,

    The header AD (besides logo) is yet not visible on mobiles.

    Any fix on that?

  •  93
    djwd replied

    Hi there,

    Could you show an example please?

    Regards
    djwd

  • Pawan replied

    See the attached image.

    The Image with AD has the adsense code placed in middle content slot.

    When i place the ADsense code in header slot provided. It does not show up on Mobiles. Only the logo shifts to the left in menubar. Check the other screenshot.

  •  93
    djwd replied

    Got it, thanks!

    Will release a fix as soon as possible, thank you for your feedback.

    If you're in urgent with this allow me log in to your dashboard and I'll try to temporary fix it for you. 

    Regards
    djwd

  • Pawan replied

    Update: i just noticed that Double AD widget also isnt working. No AD's show up.


    P.S- When's the next update due :)

  •  93
    djwd replied

    Hi there,

    The double ad not showing up might depend on the Ad sizes not having enough space to display. Do you have a live example set with double google AdSense code I can inspect? Thanks

    Next update will most likely be released next week.

    Thanks for your feedback.

    Regards
    djwd

  • Pawan replied

    Okay, I've added double AD widget just after social buttons (after social buttons) in sidebar.  After you have checked, do let me know.

  •  93
    djwd replied

    Hi there,
    it came across the weekend unfortunately. I couldn't find it but you might removed it already, don't worry though, I'll find a way to test this myself. Thanks for your help.

    Regards
    djwd

  • Pawan replied

    widget is still present after social buttons

  •  93
    djwd replied

    Hi there,

    Sorry I was looking at the homepage, could find it on the single post, thanks.

    There is this error triggering in your console: 

    Uncaught TagError: adsbygoogle.push() error: No slot size for availableWidth=0

    This error seems to occur when Google AdSense code is trying to insert ad and if it doesn’t find proper width to the parent container where its trying to insert ad.

    E.g if you're trying to load a double 125px width ads, pasting this CSS snippet in the Custom CSS textarea should fix it:

    .left-ad,
    .right-ad {
        width: 125px;
        height: auto
    }

    I'll look up for a 'universal' fix to include in the next update as well.

    Hope that helps,
    thanks for your feedback.

    Regards
    djwd

  • Pawan replied

    Updated the theme. The header ad still doesn't show up on mobiles. (i've changed back to mid ad). Double AD widget did work with the CSS you provided.

  • Pawan replied

    Is it possible to have the middle show up like (check img-1). Img2 is currently default layout for the theme.

  •  93
    djwd replied

    Hi there,

    1. Tested the top ad on mobiles several times, works for me. Make sure you cleared any cache you might have (CDN, Browser, plugins).
    If it still doesn't work, If you allow me and credentials you provided are still valid I'll take a peek.

    2. Would be possible but it would require some customization to template files in order to load the advert on another location, you most likely want it on single.php or content-single.php

    Regards
    djwd

  •   Pawan replied privately
  •  93
    djwd replied

    Hi,

    1. The Ad is not displaying at all for me, hence I couldn't test the mobile issue. There is an error triggered by google:

    Uncaught TagError: adsbygoogle.push() error: All ins elements in the DOM with class=adsbygoogle already have ads in them.

    2. Tried to put you on the right tracks already, that would fall under 'item customization'  that unfortunately aren't covered by regular support policy.  I could help on a freelance basis or you can seek for help on Envato Studio. Thank you for your understanding.

    3.  That is unlikely to be a theme bug as the AD textareas simply outputs the code in them. Since it only happens with amazon services, it looks to be a problem with the CSS loaded by the widget, which is not 'universal'. After a quick inspection that might work, but again you might want to check with their support channels.

    .amzn-native-container {margin: 0 auto!important;}

    4. Will look into that, thanks for your feedback.

    Regards
    djwd