Okay
  Public Ticket #430880
WP 4.2 Support
Closed

Comments

  • Levi started the conversation

    I was just wondering if the theme is 4.2 compatible and if not, is there an estimated time when it will be?

  •  93
    djwd replied

    Hi there,

    did you face some issues or haven\'t tried that out yet? No issue arose so far with WP 4.2, although if you don\'t have a stage environment to test it out, you might want to wait a bit more to update just to make sure.

    Regards
    djwd

    Regards
    djwd

  • Levi replied

    I don\'t mind waiting. I just didn\'t see 4.2 listed as being compatible in the theme details so I thought I might save some time by asking you rather than try it out myself.

  • Levi replied

    I just updated to 4.2 and noticed a couple errors dealing with the sidebars.

    I believe this has to do with missing id values when using register_sidebar(). Any place you use register_sidebar() in your theme will have to be updated before it\'s truly 4.2 compatible.

    EDIT: Also just to note, it appears all the included sidebars do have ids. It\'s only the sidebars generated in from the theme options that are causing issues.

    Notice: register_sidebar was called incorrectly. No id was set in the arguments array for the \"Sidebar Name\" sidebar. Defaulting to \"sidebar-12\". Manually set the id to \"sidebar-12\" to silence this notice and keep existing sidebar content. Please see Debugging in WordPress for more information.
    
  •  93
    djwd replied

    Hi there,

    thank you very much for your feedback. Being a simple notice, it shouldn\'t affect any functionality, I\'ll fix this for the next update. Thanks again for the heads-up.

    Regards
    djwd

    Regards
    djwd

  • Levi replied

    Also noticing the media manager does not load on post pages. (unable to set a featured image or add images to the post using the \"add media\" button.) I first noticed it on my child theme. I then tried the base mightymag theme and experienced the same behavior. Activating the Twenty Fifteen theme resolved the issue, but switching the theme just to add an image is less than ideal.

    This problem also seems to affect adding links. The link list just never populates. The spinner remains active, there are no errors via console.

  • Levi replied

    Just wanted to update you on this. I found a 4.2.2 compatible sidebar plugin (Content Aware Sidebars), replaced and then deleted the sidebars generated with the theme. Once I did that, the notices were of course gone, but the media manager also works again.

  •  93
    djwd replied

    Hi there,

    Of course you shouldn\'t be switching theme to upload some media. I were able to replicate the issue. I\'m going to dig into this in a while and possibly release a fix within the next upcoming update. Thank you very much for the update, your information will be very useful indeed!

    Regards
    djwd

    Regards
    djwd