I'm running into a problem with post thumbnail image size. It also seems apparent on the demo. Especially when the homepage main widget size is larger. http://mightymag.staging.wpengine.com/homepage-4/
Here you can see the images are sized to 555x270 however the thumbnail generated is sized to the 'loop' image size. 370x180 which results in unwanted distortion.
I've already made a child theme, and replaced the add_image_size function. I added a new entry 'big-loop' with the desired size, and changed loop to big-loop in wg-main-cat.php but I'm still getting the small images.
I've ran regenerate thumbnails several times but it doesn't fix the issue.
images are not looking distorted in proportions on the linked page, but as you say the are bigger than natural image size. Since the result is still acceptable, we could not create another image size only for that specific layout, not to flood servers with too many (as there are plenty already.)
Your modification seems to be correct though, maybe it's only a caching problem. Without seeing it it's pretty hard to tell
Regards djwd
PS: Just out of curiosity, may I ask where did you get that staging.wpengine link? That is a testing area, the main domain for the live demo is http://mightymag.djwd.me
I guess I meant pixelated rather than distorted, but that's just a matter of semantics. I'm not really sure how you can call a 150% scaled image acceptable, especially with high dpi devices in the mix. I don't have any caching enabled, but I'll continue to look for why the modification isn't taking effect, I just thought you'd want to know about the image scaling since it contrasts with the rest of the theme's high standards.
I believe the link is part of the imported demo content main menu. Community > Forums
That would work, but I'm using a customized two column homepage layout, so the res would still be low at 555x270.
In order to make the function pluggable, I think the ! operator has to be used with function_exists. As it is now, it overwrites any customizations in the child's functions.php
No worries on the the support, but really there's a lot in your functions.php that isn't very child theme friendly. As it is now, it's impossible to customize the widgets or anything outside of the base directory. It's looking more and more like I'll have to customize the main theme and run a diff/patch for updating
As a suggestion, in the future you may want to use get_stylesheet_directory() in your functions.php for commonly customized files and prepackage a child theme with all the necessary files that can be altered. That would allow users to make any edits they want within those files and it would run exactly the same when the main template is enabled as opposed to the child.
This all stems from not being able to alter the homepage widget. It's defined on line 127 of your functions.php
in order to use my child themes wg-main-cat.php I would need to add get_stylesheet_directory() to the base of that path. I can't rewrite that line as it would be overwritten when the main theme's functions.php is run after the child's functions.php
Child themes support was added at later stage of theme development, hence there might be things that can still be improved. I'll consider your suggestions for next updates, thanks for your feedback.
I'm running into a problem with post thumbnail image size. It also seems apparent on the demo. Especially when the homepage main widget size is larger.
http://mightymag.staging.wpengine.com/homepage-4/
Here you can see the images are sized to 555x270 however the thumbnail generated is sized to the 'loop' image size. 370x180 which results in unwanted distortion.
I've already made a child theme, and replaced the add_image_size function. I added a new entry 'big-loop' with the desired size, and changed loop to big-loop in wg-main-cat.php but I'm still getting the small images.
I've ran regenerate thumbnails several times but it doesn't fix the issue.
Hi there,
images are not looking distorted in proportions on the linked page, but as you say the are bigger than natural image size. Since the result is still acceptable, we could not create another image size only for that specific layout, not to flood servers with too many (as there are plenty already.)
Your modification seems to be correct though, maybe it's only a caching problem. Without seeing it it's pretty hard to tell
Regards
djwd
PS: Just out of curiosity, may I ask where did you get that staging.wpengine link? That is a testing area, the main domain for the live demo is http://mightymag.djwd.me
Regards
djwd
I guess I meant pixelated rather than distorted, but that's just a matter of semantics. I'm not really sure how you can call a 150% scaled image acceptable, especially with high dpi devices in the mix. I don't have any caching enabled, but I'll continue to look for why the modification isn't taking effect, I just thought you'd want to know about the image scaling since it contrasts with the rest of the theme's high standards.
I believe the link is part of the imported demo content main menu. Community > Forums
Hi there,
You have a point, I agree. Will add the new image size in next update scheduled for next week.
Regards
djwd
Regards
djwd
One other request for the next update.
I wasn't able to override the add_image_size functions without adding the ! operator to line 277 of the original template functions.php
if ( ! function_exists( 'add_image_size' ) ) {Sorry I'm not quite sure I got this, I'll add the image size myself for the next update, you'll only need to regenerate your thumbnails after that.
Regards
djwd
Regards
djwd
That would work, but I'm using a customized two column homepage layout, so the res would still be low at 555x270.
In order to make the function pluggable, I think the ! operator has to be used with function_exists. As it is now, it overwrites any customizations in the child's functions.php
Ok I missed the fact you're using a child theme. I'll take this into consideration when working on that.
Thanks for your feedback
Regards
djwd
FYI: Unfortunately I won't be able to provide support tomorrow, any follow up will be processed on Monday. Thanks for your patience.
Regards
djwd
No worries on the the support, but really there's a lot in your functions.php that isn't very child theme friendly. As it is now, it's impossible to customize the widgets or anything outside of the base directory. It's looking more and more like I'll have to customize the main theme and run a diff/patch for updating
As a suggestion, in the future you may want to use get_stylesheet_directory() in your functions.php for commonly customized files and prepackage a child theme with all the necessary files that can be altered. That would allow users to make any edits they want within those files and it would run exactly the same when the main template is enabled as opposed to the child.
This all stems from not being able to alter the homepage widget. It's defined on line 127 of your functions.php
include_once('inc/widgets/wg-main-cat.php'); // HomePagein order to use my child themes wg-main-cat.php I would need to add get_stylesheet_directory() to the base of that path. I can't rewrite that line as it would be overwritten when the main theme's functions.php is run after the child's functions.php
Child themes support was added at later stage of theme development, hence there might be things that can still be improved. I'll consider your suggestions for next updates, thanks for your feedback.
Regards
djwd
Regards
djwd
Thanks. Love the theme by the way! Really looking forward to child theme support.